Fix schema validation for recovery.pgBaseBackup.secret #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
0xfabio
force-pushed
the
652-fix-pg-basebackup-secret-mismatch
branch
from
66c1389 to
122d12b
Compare
Signed-off-by: Fabio Keller <[email protected]>
0xfabio
force-pushed
the
652-fix-pg-basebackup-secret-mismatch
branch
from
122d12b to
e84745b
Compare
Author
|
Hi @itay-grudev, any chance we could get a review here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into the already opened issue, so I thought I could quickly fix this.
#652
Testing
Running the following command fails with the current main, but works as expected in with this fix: